-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print tweaks #25164
Print tweaks #25164
Conversation
This should address some inconsistencies between browsers when printing. It applies a min-width to the body so that the content better resembles what your might see on your screen. I've made it a variable for easy customizing, too.
…tent print experience across browsers
Hi, Great news! You mention that this should make Chrome and Safari look similar. The problem I had was with Chrome vs IE. Is it likely that this issue will be fixed too? Thank you! |
Just verified this improves things in IE11 and Edge. It's not 100%, but it's an improvement for sure. |
This broke my invoice page |
To clarify, it's supposed to be a smaller paper, so I had |
I'll add here that this caused Chrome's print dialog to remove the "Orientation" option for me. |
Chrome margins are wrong. why is this set to |
Adds two new variables for printing—page
size
andmin-width
for the<body>
and.container
. Using the docs homepage as my example, this printed the most similar in macOS Chrome and Safari. I'll check in on Windows browsers before merging.While working on this, a few things came to light:
@page
'ssize
, hence themin-width
s.@page
. Addingmargin
or!important
broke thesize
property.I'm expecting even more issues across other browsers as I get into them.
Hopefully fixes #23864 and fixes #23992.
/cc @tigermarques @michaelkrieger